-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
충남대 FE_강병현 4주차 과제 Step4 #103
Open
kang-kibong
wants to merge
41
commits into
kakao-tech-campus-2nd-step2:kang-kibong
Choose a base branch
from
kang-kibong:step4
base: kang-kibong
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
충남대 FE_강병현 4주차 과제 Step4 #103
kang-kibong
wants to merge
41
commits into
kakao-tech-campus-2nd-step2:kang-kibong
from
kang-kibong:step4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taehwanno
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
step4 고생하셨습니다.
#74 병합 후 충돌 발생하고 있어서 해결되면 병합하도록 하겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요. 카테캠 프론트엔드 파트 수강 중인 충남대학교 강병현입니다. 😊
죄송하게도, 금일 step3, 4 구현과 이전 step에서 코드리뷰 주신 내용을 기반으로 늦게나마 리팩토링을 진행하였습니다.
4주차 과제는 다음과 같이 진행해보았습니다.
👨🏻💻 해결 과정
1️⃣ 1단계 - 상품 상세 페이지 & 상품 결제하기 Form 구현하기
2️⃣ 2단계 - Validation 구현하기
3️⃣ 3단계 - React Hook Form를 사용하여 기존의 Form 리팩터링
🛠️ 코드 리뷰 반영
📄 요구 사항
Code Spell Checker
extension을 통한 오타 수정